Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsquash images in docs #439

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Unsquash images in docs #439

merged 3 commits into from
Mar 1, 2025

Conversation

drbenvincent
Copy link
Collaborator

@drbenvincent drbenvincent commented Feb 27, 2025

  • Closes Images in the docs are squashed  #425
  • Constrains version to myst-nb<=1.0.0. Though this seems suboptimal because it's on version 1.2.0 now. I've tried building docs locally with the latest version but that still suffers from the same squashed image problem.

📚 Documentation preview 📚: https://causalpy--439.org.readthedocs.build/en/439/

@drbenvincent
Copy link
Collaborator Author

Failing checks will hopefully be resolved in #437, but open to any input :)

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.40%. Comparing base (0d6e4f8) to head (e92eea6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          31       31           
  Lines        1985     1985           
=======================================
  Hits         1874     1874           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drbenvincent drbenvincent added the documentation Improvements or additions to documentation label Mar 1, 2025
@drbenvincent drbenvincent requested a review from juanitorduz March 1, 2025 12:14
@drbenvincent
Copy link
Collaborator Author

Seems to have fixed things in the docs
Screenshot 2025-03-01 at 12 58 16

@drbenvincent drbenvincent merged commit 7a2e385 into main Mar 1, 2025
8 checks passed
@drbenvincent drbenvincent deleted the unsquash-images-in-docs branch March 1, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images in the docs are squashed
2 participants