Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get plot data for prepostfit experiments #438

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

lpoug
Copy link

@lpoug lpoug commented Feb 7, 2025


Note: First time doing a proper PR so not sure if all pre-requisites are here.


📚 Documentation preview 📚: https://causalpy--438.org.readthedocs.build/en/438/

@lpoug lpoug marked this pull request as ready for review February 17, 2025 08:44
@drbenvincent
Copy link
Collaborator

Humble apologies for taking so long to getting to this PR @lpoug. I've unfortunately not had much time to spend on CausalPy as I'd have liked, but hoping to catch up with the backlog.

There are currently a couple of issues with the remote checks. I'm hoping to get these resolved in #437, at which point I'll test this out locally and give feedback if necessary before we can merge this :)

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 92.98%. Comparing base (3a7ddea) to head (6dca884).

Files with missing lines Patch % Lines
causalpy/experiments/prepostfit.py 12.00% 22 Missing ⚠️
causalpy/experiments/base.py 46.15% 7 Missing ⚠️
causalpy/plot_utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   94.40%   92.98%   -1.43%     
==========================================
  Files          31       31              
  Lines        1985     2025      +40     
==========================================
+ Hits         1874     1883       +9     
- Misses        111      142      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpoug
Copy link
Author

lpoug commented Mar 3, 2025

Humble apologies for taking so long to getting to this PR @lpoug. I've unfortunately not had much time to spend on CausalPy as I'd have liked, but hoping to catch up with the backlog.

There are currently a couple of issues with the remote checks. I'm hoping to get these resolved in #437, at which point I'll test this out locally and give feedback if necessary before we can merge this :)

Absolutely no problem whatsoever @drbenvincent! Let me know when the time comes, I'll be around 😄

@drbenvincent drbenvincent added the enhancement New feature or request label Mar 3, 2025
@drbenvincent
Copy link
Collaborator

Hi @lpoug. I pushed some changes, can you make sure to pull the latest version?

I'll try to review this in the next few days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get model results data
2 participants