Codespell CI Job #411
Merged
Codespell CI Job #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 31 31
Lines 1985 1985
=======================================
Hits 1874 1874
Misses 111 111 ☔ View full report in Codecov by Sentry. |
|
@drbenvincent -- here's the related PR to use the codespell check on the jupyter notebooks within CI instead of the pre-commit check |
|
Looks good @westford14. Let's see if @maresb has any specific comments... |
maresb
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
This looks great! Thanks a lot @westford14 for splitting it up like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From conversation here: #403 (comment) -- we are now separating the
codespellcheck for the jupyter notebooks into a separate CI job since they most likely don't change as often and running it within apre-commitcheck is overkill📚 Documentation preview 📚: https://causalpy--411.org.readthedocs.build/en/411/