Rewrite scalar dot as multiplication #1205#1263
Open
SwarnimShekhar wants to merge 1 commit intopymc-devs:v2from
Open
Rewrite scalar dot as multiplication #1205#1263SwarnimShekhar wants to merge 1 commit intopymc-devs:v2from
SwarnimShekhar wants to merge 1 commit intopymc-devs:v2from
Conversation
ricardoV94
requested changes
Mar 5, 2025
Comment on lines
+299
to
+301
| # new condition to handle (1,1) @ (1,1) | ||
| if a.ndim == 2 and b.ndim == 2 and a.shape == (1, 1) and b.shape == (1, 1): | ||
| return [a * b] # Direct elementwise multiplication |
Member
There was a problem hiding this comment.
This was already handled, the issue that was not handled was for the care dot (not the blockwised versions) that this rewrite tracks.
Also a.ndim is redundant if you are checking the shape explicitly. More important you have to use static shape a.type.shape not the symbolic shape a.shape, as is done in the rest of this function
Author
There was a problem hiding this comment.
I will look into that again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1263.org.readthedocs.build/en/1263/