fix several tests related to constants #10013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temyurchenko
commented
Oct 9, 2024
Comment on lines
23
to
28
| def test_all_elements_without_parent(self) -> None: | ||
| node = astroid.extract_node("__all__ = []") | ||
| node.value.elts.append(astroid.Const("test")) | ||
| node.value.elts.append(astroid.Const("test", parent=None)) | ||
| root = node.root() | ||
| with self.assertNoMessages(): | ||
| self.checker.visit_module(root) |
There was a problem hiding this comment.
I don't think it's a good test. Why should adding a constant not result in messages? That's just asserting implementation quirks. We should test the opposite, we should test that synthetic constants result in the same messages.
IMO
I've added some tests that test regressions in the tests. I've also made the message to include the number of times a certain message is missing or extra. Without it, I had a very confusing experience, when I seemed to have the message and yet the test-suite reported that I don't. Turned out, I had to add four more of the same!
jacobtylerwalls
force-pushed
the
fix-constant-tests
branch
from
bd66249 to
37df2ed
Compare
jacobtylerwalls
added
the
Skip news 🔇
|
Hi @temyurchenko 👋 We released an alpha of astroid 4 and updated your branch to use it. Would you mind taking a look at that last test failure? Many thanks. |
Hey, for sure! Hopefully, within the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some tests that test regressions in the tests.
I've also made the message to include the number of times a certain
message is missing or extra. Without it, I had a very confusing
experience, when I seemed to have the message and yet the
test-suite reported that I don't. Turned out, I had to add four
more of the same!
Type of Changes
Description
I'd be surprised if it passes the tests right now. This will need a new version of astroid to pass, specifically, pylint-dev/astroid#2602