Replace AddObject() with AddObjectRef() #3406
Conversation
MightyJosip
added
the
Code quality/robustness
| if (PyModule_AddObject(module, "BufferProxy", | ||
| (PyObject *)&pgBufferProxy_Type)) { | ||
| Py_DECREF(&pgBufferProxy_Type); | ||
| if (PyModule_AddObjectRef(module, "BufferProxy", |
There was a problem hiding this comment.
If we're going through these anyways, might as well use PyModule_AddType so you don't need to do the PyType_Ready's either.
There was a problem hiding this comment.
Actually, the problem with that is the following: at the moment, we still allow XType classes (like SurfaceType, RectType, EventType... are still declared. And AddType would use the name from .tp_name, so it would be regular "Surface".
Maybe do this for pygame3, once we remove those XType classes?
|
It's also confusing to see replacements for things that didn't previously have an incref. |
Yea you are right, that comment is mostly for encapsulate_api, and in the current master if I print Py_REFCNT of apiobj, it is 1. However, after this PR it is indeed 2 like you said. I will remove it from those places, and use it only when we actually increase the ref |
Since Python 3.13 PyModule_AddObject() is soft deprecated. This PR replaces it with newer function, PyModule_AddObjectRef(). It was changed following the way adviced in the official documentation between versions 3.9 <-> 3.14
