Add Color.hex

[damusss]

Followed the New API routine for this property. FAQ below.

Why, if it can be done in one line?

That's not a reason not to add a shortcut. Other color shortcuts like Color.normalized can be achieved in one line aswell, plus, how to get the Color hex with one line is not very straight forward.

Can't you use the built in hex function?

That function wasn't made for correct representation of hex colors, so Color(hex(Color)) can easily error, for example in the following cases: hex(Color(1, 2, 3)) -> "0x10203ff" (no trailing zero; ValueError) or hex(Color(0, 0, 0, 255)) -> "'0xff" (not long enough; ValueError).

[ankith26]

LGTM, thanks! 💯

As it is new API, requesting atleast 2 more approvals in addition to mine, having more eyes on this PR will be better.

[Matiiss]

LGTM, left a couple comments, but nothing that would necessarily have to block this PR

[damusss]

all suggestions are good I'll fix them today

[ankith26]

The latest commit broke formatting of a test file.

[aatle]

Checks seem to be failing because of a bug in package pyproject-metadata, see pypa/pyproject-metadata#239: fixed but affects version 0.9.1.
I think this issue can be fixed by requiring "pyproject-metadata!=0.9.1".

[Starbuck5]

I don't really see this why should be added.

The FAQ in the PR description seems to assume this is a thing people want to do, but I can't think of why I would want to generate a hex string from a color object.

[aatle]

The primary reason is for displaying and inputting for user, not really for internal code. The hex rgb representation is the standard way to display, port, input colors; every color picker supports this format. Therefore it makes sense to add a shortcut.

If a pygame program wanted to allow the user to pick any color for something, this would be useful for both labelling and inputting the color.

[aatle]

You need to add a corresponding classmethod from_hex(), in accordance with every other settable color format. So that it's possible to use the setter in an expression.

[Matiiss]

You need to add a corresponding classmethod from_hex(), in accordance with every other settable color format. So that it's possible to use the setter in an expression.

Not necessary, it's already possible like so

pygame.Color("#hexstr")

[aatle]

I still think it could be beneficial to add it. It is explicit and could differentiate hex strings from color name strings (useful for input), plus more consistency.
Otherwise I think a note should be added, it's easy to miss the hex overload in the mass of constructor overloads.

[Starbuck5]

I'm okay with this, I suppose. Aatle's stated use case makes sense.

I don't see a need to add from_hex in this PR.

[Starbuck5]

Also IDK what's up with the tests, but maybe if you rebase @damusss it would rerun and be green and pretty?