Simplify the test for swapped operand operations #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 71.13% 71.11% -0.02%
==========================================
Files 74 74
Lines 9437 9439 +2
Branches 1211 1210 -1
==========================================
Hits 6713 6713
- Misses 2551 2552 +1
- Partials 173 174 +1 ☔ View full report in Codecov by Sentry. |
eric-wieser
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for PR#437.
The pytest
TestBasicAlgebra.test_swapped_operands()is too complicated. As suggested by @eric-wieser, the validation can be made by using some picked /convenient numbers fromg3only.