Skip to content

General JobType Coverage #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opalmer wants to merge 66 commits into
base: master
Choose a base branch
from
Open

General JobType Coverage #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
8de0cb1
adding test_reraises_notimplemented
opalmer Oct 26, 2015
6cd85a7
add TestJobTypeNode.test_output
opalmer Oct 26, 2015
0bd6323
switch to contextlib.nested for test_reraises_notimplemented
opalmer Oct 26, 2015
e3798fd
adding TestJobTypeAssignments
opalmer Oct 26, 2015
15d6125
initial commit of TestJobTypeTempDir
opalmer Oct 26, 2015
a712f2b
adding missing handling for IOError and WindowsError
opalmer Oct 26, 2015
244f481
removing unused imports
opalmer Oct 26, 2015
e21936d
adding tests for directory creation in tempdir()
opalmer Oct 26, 2015
02a04e2
finishing up TestJobTypeTempDir
opalmer Oct 26, 2015
519943a
remove unused import
opalmer Oct 26, 2015
cd2e342
added TestJobTypeLoad and TestJobTypeCloseLogs
opalmer Oct 26, 2015
33ca9c6
added TestJobTypeEmptyMethodSignatures
opalmer Oct 26, 2015
1051736
add missing test test_spawn_persistent_process
opalmer Oct 26, 2015
30832a8
optimize get_uid_gid
opalmer Oct 26, 2015
72286bb
adding TestJobTypeGetUidGid
opalmer Oct 26, 2015
23cb112
raise TypeError if jobtype_default_environment is not a dictionary
opalmer Oct 27, 2015
68d7546
initial TestJobTypeGetEnvironment
opalmer Oct 27, 2015
5d2e52a
adding tests for key/value conversion to string in get_environment()
opalmer Oct 27, 2015
bf25666
small readability change
opalmer Oct 27, 2015
ab688fe
improved documentation for get_command_list() and expandvars()
opalmer Oct 28, 2015
6a80c6d
added TestGetCommandList
opalmer Oct 28, 2015
f1d23c0
fix test name
opalmer Oct 28, 2015
133de4e
use _check_csvlog_path_inputs, not an assertion, to check input
opalmer Oct 28, 2015
f16a758
adding TestJobTypeGetCSVLogPath
opalmer Oct 28, 2015
51cce39
adding interface test for get_command_data()
opalmer Oct 28, 2015
20f9a98
adding map_path() tests and some TODOs
opalmer Oct 28, 2015
bd9cbb4
add missing jobtype_include_os_environ configuration option
opalmer Oct 28, 2015
864c9c1
added TestJobTypeExpandVars()
opalmer Oct 29, 2015
ec1dcee
wip commit
opalmer Oct 29, 2015
da19521
removing wip code for now
opalmer Oct 30, 2015
ef7d3ea
adding test for before_start()
opalmer Oct 30, 2015
aaf90b1
adding before_spawn_process() test
opalmer Oct 30, 2015
abdaaeb
bugfix, using wrong logger in log_stderr_line()
opalmer Oct 30, 2015
7e0a138
added TestJobTypeLogLine()
opalmer Oct 30, 2015
fe1f98d
bugfix, comparisons to False should use is or leave it out
opalmer Oct 30, 2015
87da585
fixing handle_stdout_line/handle_stderr_line so they're identical
opalmer Oct 30, 2015
01c338e
check if result is False first
opalmer Oct 30, 2015
91427ba
whitespace fix
opalmer Oct 30, 2015
821e91b
adding TestJobTypeHandleStderrLine()/TestJobTypeHandleStdoutLine()
opalmer Oct 30, 2015
82b541d
adding TestJobTypeGetLocalTaskState()
opalmer Oct 30, 2015
e779774
added TestJobTypeIsSuccessful()
opalmer Oct 30, 2015
1756018
added TestJobTypeProcessStarted()
opalmer Oct 30, 2015
5bf8d45
adding TODO
opalmer Oct 30, 2015
1c920b3
Merge branch 'master' of github.com:pyfarm/pyfarm-agent into jobtype_…
opalmer Oct 31, 2015
df252be
Merge branch 'master' of github.com:pyfarm/pyfarm-agent into jobtype_…
opalmer Nov 1, 2015
4f572a5
rolling this into another PR
opalmer Nov 1, 2015
b2e0bb7
moved this into #341
opalmer Nov 1, 2015
3e7418f
moved this change into #342
opalmer Nov 1, 2015
e129c44
moved this change to #343
opalmer Nov 1, 2015
cb94a8f
moved change to #344
opalmer Nov 1, 2015
6c886af
readd whitespace
opalmer Nov 1, 2015
5e6db29
moved to change #345
opalmer Nov 1, 2015
d3c60df
moved to change #346
opalmer Nov 1, 2015
4c5e52b
Merge branch 'master' of github.com:pyfarm/pyfarm-agent into jobtype_…
opalmer Nov 1, 2015
c264103
moved change into #347
opalmer Nov 1, 2015
645ab52
moved change into #347
opalmer Nov 1, 2015
a656395
removing unused imports
opalmer Nov 1, 2015
852fcb1
moved change into #348
opalmer Nov 1, 2015
8072cc9
Fix date format in test_uses_provided_create_time
guidow Jan 28, 2016
a4338de
merging with origin/master
opalmer Jan 29, 2016
c6480ab
Merge pull request #352 from guidow/fix_dateformat_in_test
opalmer Jan 30, 2016
f15e56f
Merge branch 'master' of github.com:pyfarm/pyfarm-agent into jobtype_…
opalmer Jan 30, 2016
0bad35d
Merge branch 'jobtype_coverage' of github.com:pyfarm/pyfarm-agent int…
opalmer Jan 30, 2016
d448687
fixing a couple of bugs that slipped through
opalmer Jan 30, 2016
60856fb
merging with origin/master
opalmer Jan 30, 2016
95cf303
fix reference to is_administrator
opalmer Jan 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pyfarm/jobtypes/core/jobtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@

FROZEN_ENVIRONMENT = ImmutableDict(os.environ.copy())

try:
WindowError
except NameError: # pragma: no cover
WindowError = OSError


class TaskNotFound(Exception):
pass
Expand Down Expand Up @@ -489,7 +494,7 @@ def tempdir(self, new=False, remove_on_finish=True):
os.makedirs(parent_dir)
except (OSError, IOError, WindowError) as error:
if error.errno != EEXIST:
logger.error("Failed to create %s: %s", parent_dir, e)
logger.error("Failed to create %s: %s", parent_dir, error)
raise

self._tempdirs.add(parent_dir)
Expand Down
Loading