Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
command: |
pip install ".[docs]"
cd docs/
make html
make html SPHINXOPTS="-W"

test_deprecation_warnings:
parameters:
Expand Down
4 changes: 2 additions & 2 deletions docs/api_reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ Modules

.. toctree::
:maxdepth: 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add blank spaces (if you use the editorconfig plugin it will remove trailing whitespaces automatically ;))

modules/spharpy.beamforming
modules/spharpy.indexing
modules/spharpy.interpolate
modules/spharpy.plot
modules/spharpy.samplings
modules/spharpy.spatial
modules/spharpy.special
modules/spharpy.spherical
modules/spharpy.transforms

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
spharpy.special
-----------------
---------------

.. automodule:: spharpy.special
:members:
:special-members: __init__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this was added, since currently there are no classes inside special

:undoc-members:
:show-inheritance:
2 changes: 1 addition & 1 deletion spharpy/classes/audio.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class SphericalHarmonicSignal(Signal):
fft_norm : str, optional
The normalization of the Discrete Fourier Transform (DFT). Can be
``'none'``, ``'unitary'``, ``'amplitude'``, ``'rms'``, ``'power'``,
or ``'psd'``. See :py:func:`~pyfar.dsp.fft.normalization` and [#]_
or ``'psd'``. See :py:func:`~pyfar.dsp.fft.normalization`
for more information. The default is ``'none'``, which is typically
used for energy signals, such as impulse responses.
comment : str
Expand Down
8 changes: 6 additions & 2 deletions spharpy/spherical.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ def nm_to_fuma(n, m):
and degree m, according to the FuMa (Furse-Malham)
Channel Ordering Convention.

See [#]_ for details.

Parameters
----------
n : integer, ndarray
Expand Down Expand Up @@ -137,7 +139,9 @@ def fuma_to_nm(fuma):
r"""
Calculate the spherical harmonic order n and degree m for a linear
coefficient index, according to the FuMa (Furse-Malham)
Channel Ordering Convention [#]_.
Channel Ordering Convention.

See [#]_ for details.

FuMa = WXYZ | RSTUV | KLMNOPQ
ACN = WYZX | VTRSU | QOMKLNP
Expand Down Expand Up @@ -472,7 +476,7 @@ def spherical_harmonic_basis_gradient(n_max, coordinates, normalization="n3d",


This implementation avoids singularities at the poles using identities
derived in [#]_.
derived in [#]_ and [#]_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, the singularity avoiding formulation is detailed only in the second reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mberz I tried to fix it. But I'm not into the topic, if this isnt correct, or you have an better idea, feel free to change here in the PR directly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)



References
Expand Down