add plt.show() to notebooks #109
Conversation
hoyer-a
requested review from
a team,
ahms5,
f-brinkmann,
mberz and
sikersten
There was a problem hiding this comment.
the interactive example in binaural_synthesis is not working, is there a solution?
otherwise approved
There was a problem hiding this comment.
@ahms5 as far as I remember, the example never worked in html. If we want to fix this, I would suggest to make it a separate issue.
| "nbformat_minor": 2, | ||
| "nbsphinx": { | ||
| "execute": "never" | ||
| } | ||
| "nbformat_minor": 2 |
There was a problem hiding this comment.
Not sure why running the notebook updated this metadata, i reverted the changes.
No, and it will not work with the current implementation since there is no active interpreter running to execute the python code. This example needs to be run locally or on binder. |
| "\n", | ||
| "pf.plot.time(audio_data)" | ||
| "pf.plot.time(audio_data)\n", | ||
| "plt.show()" |
There was a problem hiding this comment.
No figure is shown at https://pyfar-gallery--109.org.readthedocs.build/en/109/contribute/template_oer.html. Is this how it should be?
There was a problem hiding this comment.
As far as I remember this notebook does not get executed (and is not intended to), but statically rendered, in which case there's also not going to be a plot output.
There was a problem hiding this comment.
I also remember that this was on purpose.
But i just realized that the latest template-notebook is stored in closed-educational and that #107 is still open.
Since sometimes plots are not displayed using %matplotlib inline, plt.show() is added to all plots for safety.