[MRG] Check socket still exists before sending data #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 8647 8642 -5
=========================================
- Hits 8647 8642 -5
|
scaramallion
changed the title
hzchet
reviewed
Dec 21, 2023
| sock = cast("AssociationSocket", self.socket) | ||
| sock.send(pdu.encode()) | ||
| evt.trigger(self.assoc, evt.EVT_PDU_SENT, {"pdu": pdu}) | ||
| if self.socket is not None: |
There was a problem hiding this comment.
what if self.socket.socket is None? shouldn't there be an if statement for that just in case? i think it might be the solution for this issue #806
There was a problem hiding this comment.
Ideally the state machine and reactors should manage things so it never tries to send data while None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Tasks