Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test file with a non byte-aligned segmentation #15

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

CPBridge
Copy link
Contributor

Describe the changes

Add a new test file that is a binary, natively encoded segmentation (with BitsAllocated=1) whose frames contain a number of pixels that are not a multiple of 8. Such files are valid but tricky to deal with because of the misalignment of the frame and byte boundaries.

Partial fix for pydicom/pydicom#2134

Tasks

  • In a branch on your fork of pydicom-data, add or modify data files
  • Create a pull request for pydicom-data
  • Update the commit hash for the urls in a fork/branch of the pydicom file [urls.json]https://github.com/pydicom/pydicom/blob/master/pydicom/data/urls.json and create a pydicom pull request
  • pydicom unit tests passing
  • Documentation updated (if needed)

@CPBridge
Copy link
Contributor Author

I should mention that to create this I took the existing liver image (originally 512 x 512) and just cropped it down to a "weird" size (510 x 511) and correctly re-encoded the pixels with bit-packing.

@scaramallion scaramallion merged commit 8da482f into pydicom:master Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants