-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shards
to valid_encodings
to enable sharded Zarr writing
#9948
base: main
Are you sure you want to change the base?
Conversation
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
Thanks @jacobbieker for opening a PR. Do you have time to add a roundtrip test for this? This test would be a good test to emulate: xarray/xarray/tests/test_backends.py Lines 2486 to 2494 in 6bea715
|
Yep! I think I've added one that works for that, and updated the Zarr V3 loading to include the Edit: Ah it seems to cause some issues with threads on 3.12 potentially? |
Adds
shards
to the list ofvalid_encodings
in the zarr backend, so that sharded Zarr V3s can be written.shards
not invalid_encodings
#9947