Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dask rolling #9909

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Skip dask rolling #9909

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f98260
Skip dask rolling
Illviljan Dec 18, 2024
5cb25a2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 18, 2024
17ba51b
Clearer skip
Illviljan Dec 18, 2024
23c5ce5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion asv_bench/benchmarks/rolling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import xarray as xr

from . import parameterized, randn, requires_dask
from . import _skip_slow, parameterized, randn, requires_dask

nx = 3000
long_nx = 30000
Expand Down Expand Up @@ -80,6 +80,9 @@ def time_rolling_construct(self, center, stride, use_bottleneck):
class RollingDask(Rolling):
def setup(self, *args, **kwargs):
requires_dask()
# TODO: Lazily skipped in CI as it is very demanding and slow.
# Improve times and remove errors.
_skip_slow()
super().setup(**kwargs)
self.ds = self.ds.chunk({"x": 100, "y": 50, "t": 50})
self.da_long = self.da_long.chunk({"x": 10000})
Expand Down
Loading