Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run CI on python=3.13 #9681

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

run CI on python=3.13 #9681

wants to merge 14 commits into from

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Oct 25, 2024

Missing libraries:

  • dask: dask-expr depends on pyarrow, which will support 3.13 starting with pyarrow>=18.0
  • pydap: depends on webob which uses the removed cgi stdlib (see Resolve Deprecation Warnings  pydap/pydap#319 (comment) in the "out-of-scope" section)
  • numba: as usual will take some time to support it (and thus we can't test numbagg and sparse)

reason: `dask-expr` depends on `pyarrow`, which doesn't support python
3.13 yet
reason: depends on `webob`, which makes use of `cgi`, a stdlib that got
removed in python 3.13
@keewis
Copy link
Collaborator Author

keewis commented Oct 25, 2024

Interestingly it's conda that you can't install along with python=3.13, but cftime, pandas, and possibly h5py also raise errors (I can't reproduce that locally, though). So I guess we'll have to revisit this in a couple of weeks.

@mathause
Copy link
Collaborator

Is there a reason we are installing conda? For the output of conda info and conda list? There is a micromamba info and micromamba list output in the Setup micromamba step which we could refer to instead.

@keewis
Copy link
Collaborator Author

keewis commented Nov 2, 2024

we use conda to call conda info -a, which contains information micromamba info does not include (and I don't know whether micromamba info -a exists). In theory we could use mamba info -a as well, but that also doesn't provide packages for python 3.13.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@dcherian dcherian added the plan to merge Final call for comments label Dec 3, 2024
@keewis
Copy link
Collaborator Author

keewis commented Dec 3, 2024

does numba support python=3.13 now? If not we're losing some test coverage by not testing on 3.12 (but not sure how important that is?)

@dcherian dcherian removed the plan to merge Final call for comments label Dec 3, 2024
@dcherian
Copy link
Contributor

dcherian commented Dec 3, 2024

there is an RC out so I guess we wait a little bit more

@max-sixty
Copy link
Collaborator

(fwiw unless it's more work — and tests seem to be passing already — I would vote to merge sooner rather than wait on upstream. better to have something working and fewer things in buffer...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python 3.13 to CI
4 participants