Skip to content

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Sep 17, 2025

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

https://github.com/SciTools/workflows
https://github.com/conda/conda-lock
conda lock -f environment.yml -p linux-64

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Sep 17, 2025
@Illviljan Illviljan added run-benchmark Run the ASV benchmark workflow and removed Automation Github bots, testing workflows, release automation labels Sep 17, 2025
@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Sep 17, 2025
@github-actions github-actions bot added the CI Continuous Integration tools label Sep 17, 2025
@Illviljan
Copy link
Contributor Author

Strange errors now. I wonder if parts of it (the version locks for example) needs to be merged and sit in main for a while for performance runs to start working?

@trexfeathers
Copy link

This error:

NotImplementedError: No environment setup is known for this commit of Iris.

Is because this block is turning up False. I assume Nox is not appropriate for Xarray. You could write whatever you like in this file though 👍

if noxfile.is_file():
# Our noxfile originally did not support `--install-only` - you
# could either run the tests, or run nothing at all. Adding
# `run_always` to `prepare_venv` enabled environment setup without
# running tests.
noxfile_tree = ast.parse(source=noxfile.read_text())
prep_session = next(
filter(
lambda node: getattr(node, "name", "") == "prepare_venv",
ast.walk(noxfile_tree),
)
)
prep_session_code = ast.unparse(prep_session)
if (
"session.run(" not in prep_session_code
and "session.run_always(" in prep_session_code
):
mode = Mode.NOX

@Illviljan
Copy link
Contributor Author

Yeah it looks to me I need to merge the noxfile and locks to get useful commits that asv can checkout.

·· Running delegated environment management for: delegated-pyDELEGATED at commit: 490f1e09

@trexfeathers
Copy link

Yeah it looks to me I need to merge the noxfile and locks to get useful commits that asv can checkout.

·· Running delegated environment management for: delegated-pyDELEGATED at commit: 490f1e09

Yes, when you want it working 'for real' that's probably the most sensible setup. But the structure of asv_delegated should1 allow you to write whatever custom rules you like for managing environments, so you could do something completely different as a proof-of-concept, just to get it working.

Footnotes

  1. 90% sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Github bots, testing workflows, release automation CI Continuous Integration tools run-benchmark Run the ASV benchmark workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants