Skip to content

Refactor compatibility modules into xarray.compat package #10131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Mar 15, 2025

Start of #10089

Move compatibility-related modules from xarray.core to new xarray.compat package:

  • array_api_compat.py
  • dask_array_compat.py
  • dask_array_ops.py
  • npcompat.py
  • pdcompat.py

Start of pydata#10089

Move compatibility-related modules from xarray.core to new xarray.compat package:
- array_api_compat.py
- dask_array_compat.py
- dask_array_ops.py
- npcompat.py
- pdcompat.py
@max-sixty
Copy link
Collaborator Author

Given the general approval for #10089, I'm going to merge them quite quickly, to avoid merge conflicts

I think for moving files, git should handle outstanding PRs quite well.

I'll wait before doing more intrusive things, like breaking up files

@max-sixty max-sixty merged commit b085d8b into pydata:main Mar 15, 2025
31 checks passed
@max-sixty max-sixty deleted the refactor branch March 15, 2025 02:15
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 19, 2025
* main: (67 commits)
  Refactor datetime and timedelta encoding for increased robustness (pydata#9498)
  Fix test_distributed::test_async (pydata#10138)
  Refactor concat / combine / merge into `xarray/structure` (pydata#10134)
  Split `apply_ufunc` out of `computation.py` (pydata#10133)
  Refactor modules from `core` into `xarray.computation` (pydata#10132)
  Refactor compatibility modules into xarray.compat package (pydata#10131)
  Fix type issues from pandas stubs (pydata#10128)
  Don't skip tests when on a `mypy` branch (pydata#10129)
  Change `python_files` in `pyproject.toml` to a list (pydata#10127)
  Better `uv` compatibility (pydata#10124)
  explicitly cast the dtype of `where`'s condition parameter to `bool` (pydata#10087)
  Use `to_numpy` in time decoding (pydata#10081)
  Pin pandas stubs (pydata#10119)
  Fix broken Zarr test (pydata#10109)
  Update asv badge url in README.md (pydata#10113)
  fix and supress some test warnings (pydata#10104)
  Improve handling of dtype and NaT when encoding/decoding masked and packaged datetimes and timedeltas (pydata#10050)
  Ensure KeyError raised for zarr datasets missing dim names (pydata#10025)
  Add typos check to pre-commit hooks (pydata#10040)
  Bump codecov/codecov-action from 5.3.1 to 5.4.0 in the actions group (pydata#10090)
  ...
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 19, 2025
* main: (85 commits)
  Adds open_datatree and load_datatree to the tutorial module (pydata#10082)
  Fix version in requires_zarr_v3 fixture (pydata#10145)
  Fix `open_datatree` when `decode_cf=False` (pydata#10141)
  [docs] `DataTree` cannot be constructed from `DataArray` (pydata#10142)
  Refactor datetime and timedelta encoding for increased robustness (pydata#9498)
  Fix test_distributed::test_async (pydata#10138)
  Refactor concat / combine / merge into `xarray/structure` (pydata#10134)
  Split `apply_ufunc` out of `computation.py` (pydata#10133)
  Refactor modules from `core` into `xarray.computation` (pydata#10132)
  Refactor compatibility modules into xarray.compat package (pydata#10131)
  Fix type issues from pandas stubs (pydata#10128)
  Don't skip tests when on a `mypy` branch (pydata#10129)
  Change `python_files` in `pyproject.toml` to a list (pydata#10127)
  Better `uv` compatibility (pydata#10124)
  explicitly cast the dtype of `where`'s condition parameter to `bool` (pydata#10087)
  Use `to_numpy` in time decoding (pydata#10081)
  Pin pandas stubs (pydata#10119)
  Fix broken Zarr test (pydata#10109)
  Update asv badge url in README.md (pydata#10113)
  fix and supress some test warnings (pydata#10104)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants