Added in a new object id field for mongodb #151
Conversation
I think to solve this you might need to implement this method: @classmethod
def __get_pydantic_json_schema__(
cls, schema: core_schema.CoreSchema, handler: GetJsonSchemaHandler
) -> dict[str, Any]: ...similar to how it is implemented for other types |
Co-authored-by: Yasser Tahiri <[email protected]>
Co-authored-by: Alessio Castrica <[email protected]>
|
Also can you rename the new files to snake case (mongo_object_id.py and test_mongo_object_id.py) to follow the convention of other file names? |
|
Apologies, just wanted to check before I rolled my own implementation - is there still interest in getting this across the line? If @SkandaPrasad-S doesn't have time to get to this I may take a crack at it. |
Hey @macintacos - go ahead, I tried to fix this a lot but it did not work. Could you just let me have a dummy commit to your contribution? |
| raise RuntimeError( | ||
| 'The `ObjectIdField` module requires "bson" to be installed. You can install it with "pip install ' | ||
| 'bson".' | ||
| ) |
There was a problem hiding this comment.
I don't think this is correct. It should be pip install pymongo. 😅
There was a problem hiding this comment.
Or maybe not mention what should be installed...
| @@ -49,7 +49,8 @@ all = [ | |||
| 'pycountry>=23', | |||
| 'python-ulid>=1,<2; python_version<"3.9"', | |||
| 'python-ulid>=1,<3; python_version>="3.9"', | |||
| 'pendulum>=3.0.0,<4.0.0' | |||
| 'pendulum>=3.0.0,<4.0.0', | |||
| 'bson>=0.5; python_version>="3.9"', | |||
There was a problem hiding this comment.
But here for sure should be pymongo.
|
I think a lot of ppl would benefit from this, but you can actually open a PR on But... The |
|
I really want to close this off. Can I get some help on the testing side? @sydney-runkle |
Also we can brainstorm together to fix it if needed to, please let me know if you want to |
|
Would love to see this merged! |
|
There are failing tests and conflicts in this PR, not sure when this is going to get picked up again but if you want I can open up a PR with my own implementation today based on the comments and suggestions above, should be ready by EOD. I'd also love this see this merged as I'm using heavily both pymongo and pydantic. |
Yes sounds good @Ale-Cas if you wanna work on this one 🙏🏻 |
|
Closed in favor of this #290 |
Hi everyone -> this is for issue #133
I have been able to add a new pydantic object id field but I am facing some issues with serialisation and testing it
The field is validated correctly when used like
But I am facing some problem in doing
Something.model_json_schema(mode="serialization").Can someone look through my code and help me see what is wrong or what I need to change?