-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pendulum DT support #110
Conversation
c84043c
to
3625e2d
Compare
Tests are failing due to deprecation warnings being thrown in tests out of scope of this PR. |
Just merged #113 |
3625e2d
to
1af1942
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 11 +1
Lines 665 685 +20
Branches 166 169 +3
=========================================
+ Hits 665 685 +20 ☔ View full report in Codecov by Sentry. |
Converted to draft as #111 needs to merge first. |
It looks like the blocking PR has been merged, will this feature be implemented in the near future? My team and I would appreciate support for Pendulum DT, thanks! |
99e429f
to
8590b4d
Compare
8590b4d
to
2cc8baa
Compare
PR rebased and made ready for review. |
Hey there, just wanted to bump this pr, would love the support, thanks! |
@sydney-runkle and/or @yezz123 can I get a review on this PR please? (tagged since you previously merged PRs in this repo and/or self-assigned themself to this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thanks @theunkn0wn1 🙌🏻 , I made just some small changes and a json-schema test
Adds a proxy type for pendulum.DateTime, allowing pendulum DTs to be used in Pydantic base models.
closes #112
depends on #111