Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pendulum DT support #110

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

theunkn0wn1
Copy link
Contributor

@theunkn0wn1 theunkn0wn1 commented Dec 13, 2023

Adds a proxy type for pendulum.DateTime, allowing pendulum DTs to be used in Pydantic base models.

closes #112

depends on #111

@theunkn0wn1 theunkn0wn1 force-pushed the user/jsalzedo/pydantic_dt branch 2 times, most recently from c84043c to 3625e2d Compare December 13, 2023 18:12
@theunkn0wn1
Copy link
Contributor Author

Tests are failing due to deprecation warnings being thrown in tests out of scope of this PR.
The Lint task is failing due to some seemingly out of scope error in MyPy.
Do I need to fix these?

@theunkn0wn1 theunkn0wn1 changed the title Add Pydantic DT support Add Pendulum DT support Dec 13, 2023
@hramezani
Copy link
Member

Just merged #113
The CI problem will probably be fixed by rebasing on top of the main.

@theunkn0wn1 theunkn0wn1 force-pushed the user/jsalzedo/pydantic_dt branch from 3625e2d to 1af1942 Compare December 14, 2023 21:08
@theunkn0wn1 theunkn0wn1 marked this pull request as draft December 14, 2023 21:09
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (634487f) 100.00% compared to head (1bf0d91) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          665       685   +20     
  Branches       166       169    +3     
=========================================
+ Hits           665       685   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theunkn0wn1
Copy link
Contributor Author

Converted to draft as #111 needs to merge first.

@Apilny
Copy link

Apilny commented Jan 10, 2024

It looks like the blocking PR has been merged, will this feature be implemented in the near future? My team and I would appreciate support for Pendulum DT, thanks!

@theunkn0wn1 theunkn0wn1 force-pushed the user/jsalzedo/pydantic_dt branch 2 times, most recently from 99e429f to 8590b4d Compare January 11, 2024 22:09
@theunkn0wn1 theunkn0wn1 force-pushed the user/jsalzedo/pydantic_dt branch from 8590b4d to 2cc8baa Compare January 11, 2024 22:10
@theunkn0wn1 theunkn0wn1 marked this pull request as ready for review January 11, 2024 22:10
@theunkn0wn1
Copy link
Contributor Author

PR rebased and made ready for review.

@yezz123 yezz123 self-assigned this Jan 12, 2024
@Apilny
Copy link

Apilny commented Jan 23, 2024

Hey there, just wanted to bump this pr, would love the support, thanks!

@theunkn0wn1
Copy link
Contributor Author

@sydney-runkle and/or @yezz123 can I get a review on this PR please?

(tagged since you previously merged PRs in this repo and/or self-assigned themself to this PR)

Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thanks @theunkn0wn1 🙌🏻 , I made just some small changes and a json-schema test

@yezz123 yezz123 merged commit 4f89f75 into pydantic:main Jan 25, 2024
20 checks passed
@theunkn0wn1 theunkn0wn1 deleted the user/jsalzedo/pydantic_dt branch January 25, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Pendulum
4 participants