fix: Set COLUMNS=150 for make test targets
#3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add COLUMNS=150 to `make test` to ensure consistent snapshot formatting - Add COLUMNS=150 to `make test-all-python` for all Python versions - This matches the CI environment setting and prevents local test failures due to terminal width differences Fixes snapshot test failures when running tests locally with different terminal widths.
Collaborator
|
@cjohnhanson Thanks Cody! |
DouweM
changed the title
COLUMNS=150 for make test targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into snapshot test issues in my local dev setup and the fix was to do
COLUMNS=150 make test, so thought it could be worthwhile to set in the recipes themselves.