Fix include_content not working as expected #2206
Merged
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtyavrdhn
commented
Jul 15, 2025
| ) | ||
| if not instrumentation_settings or instrumentation_settings.include_content: | ||
| run_span.set_attribute( | ||
| 'final_result', |
There was a problem hiding this comment.
I think this should also be removed if the flag is set to False, let me know if you think otherwise
There was a problem hiding this comment.
it doesn't make sense to do this when not instrumentation_settings
There was a problem hiding this comment.
Yep, I've updated it.
|
Sorry about the missed parts, I think this covers everything now. Please take a look |
|
Please rename the PR for the changelog |
adtyavrdhn
changed the title
adtyavrdhn
changed the title
alexmojaki
approved these changes
Jul 21, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571
Fixes include_content = False not working as expected for instructions and final_result