Reduce Schema clones in parquet row filter creation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
commented
Mar 17, 2025
| @@ -464,18 +464,15 @@ pub fn build_row_filter( | |||
| // `a = 1 AND b = 2 AND c = 3` -> [`a = 1`, `b = 2`, `c = 3`] | |||
| let predicates = split_conjunction(expr); | |||
|
|
|||
| let file_schema = Arc::new(file_schema.clone()); | |||
There was a problem hiding this comment.
these are deep clones (clone the entire Schema) where as with this PR only the Arc is cloned (ref count incremented)
There was a problem hiding this comment.
Yup makes total sense, I was just cautious to update the signature for build_row_filter since it seems to be a public function.
adriangb
merged commit 57c5c46
into
pydantic:fix-predicate-pushdown-sa
27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed addition to apache#15263 to reduce Schema clones