Skip to content

[Feature]-[program]- 2025 開放空間 Open space enhancement New feature or request #627 #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 21, 2025

Conversation

lisachouHC
Copy link
Contributor

修改內文(中、英)
修改圖片 static/img/events/overview/open-space-location.png
修改連結為https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view

Types of changes

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

Steps to Test This Pull Request

Expected behavior

Related Issue

Additional context

修改內文(中、英)
修改圖片
修改連結為https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view
Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for zesty-gnome-f04144 ready!

Name Link
🔨 Latest commit 59dcee0
🔍 Latest deploy log https://app.netlify.com/projects/zesty-gnome-f04144/deploys/687da129cfb0ca0008632e38
😎 Deploy Preview https://deploy-preview-647--zesty-gnome-f04144.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for classy-granita-bc2b5a ready!

Name Link
🔨 Latest commit 59dcee0
🔍 Latest deploy log https://app.netlify.com/projects/classy-granita-bc2b5a/deploys/687da129dbf73f0008a81f6e
😎 Deploy Preview https://deploy-preview-647--classy-granita-bc2b5a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@wanyewei wanyewei requested a review from Ritabear June 25, 2025 16:09
@tyuchx
Copy link
Contributor

tyuchx commented Jun 28, 2025

PR 的 Template 內容要把不需要的部分移除

Copy link
Contributor

@tyuchx tyuchx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有幾個 Prettier 錯誤,再麻煩用 lint 跑過一次

title: 'Time',
emphasis: 'Main Session: Day 2, 14:40–15:40',
title: 'Schedule',
emphasis: 'Main Session: Day 1: 12:00–13:20 (Lunch time),Day 2: 14:45–15:45',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Day 2 前面建議再多一個空格

@@ -82,7 +82,7 @@
</div>
<iframe
class="hackmd"
src="https://hackmd.io/l4JCd4AeQWqunh4PThZbRA"
src="https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這個 hackmd 似乎還沒設定公開

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有組長才可以改變權限,之前看討論串是已經開了,我再確認是不是我弄錯連結

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

地圖有點太大了,看要不要縮一下,並把 603&604 標示出來

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那這張圖需要我這邊手動改就好,還是請議程組的夥伴進行修改?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已請議程那邊看圖片問題

lisachouHC and others added 16 commits July 13, 2025 13:29
修改js文件內容(修改文案、新增參數conduct_page)
修改.vue(新增location圖片、新增subject conduct連接)
新增圖片open space extra
新增open space頁籤
修改內文(中、英)
修改圖片
修改連結為https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view
修改js文件內容(修改文案、新增參數conduct_page)
修改.vue(新增location圖片、新增subject conduct連接)
新增圖片open space extra
新增open space頁籤
Copy link
Collaborator

@Ritabear Ritabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ritabear Ritabear merged commit d0cbd8e into main Jul 21, 2025
9 checks passed
@Ritabear Ritabear deleted the #627 branch July 21, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants