-
Notifications
You must be signed in to change notification settings - Fork 39
[Feature]-[program]- 2025 開放空間 Open space enhancement New feature or request #627 #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
修改內文(中、英) 修改圖片 修改連結為https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view
✅ Deploy Preview for zesty-gnome-f04144 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for classy-granita-bc2b5a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PR 的 Template 內容要把不需要的部分移除 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有幾個 Prettier 錯誤,再麻煩用 lint 跑過一次
i18n/events/open-spaces.i18n.js
Outdated
title: 'Time', | ||
emphasis: 'Main Session: Day 2, 14:40–15:40', | ||
title: 'Schedule', | ||
emphasis: 'Main Session: Day 1: 12:00–13:20 (Lunch time),Day 2: 14:45–15:45', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Day 2 前面建議再多一個空格
pages/events/open-spaces.vue
Outdated
@@ -82,7 +82,7 @@ | |||
</div> | |||
<iframe | |||
class="hackmd" | |||
src="https://hackmd.io/l4JCd4AeQWqunh4PThZbRA" | |||
src="https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這個 hackmd 似乎還沒設定公開
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只有組長才可以改變權限,之前看討論串是已經開了,我再確認是不是我弄錯連結
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
地圖有點太大了,看要不要縮一下,並把 603&604 標示出來
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那這張圖需要我這邊手動改就好,還是請議程組的夥伴進行修改?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已請議程那邊看圖片問題
修改js文件內容(修改文案、新增參數conduct_page) 修改.vue(新增location圖片、新增subject conduct連接) 新增圖片open space extra
修改內文(中、英) 修改圖片 修改連結為https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view
修改js文件內容(修改文案、新增參數conduct_page) 修改.vue(新增location圖片、新增subject conduct連接) 新增圖片open space extra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
修改內文(中、英)
修改圖片 static/img/events/overview/open-space-location.png
修改連結為https://hackmd.io/taiCZprhTQG3uTD2g5aRwQ?view
Types of changes
Description
Steps to Test This Pull Request
Expected behavior
Related Issue
Additional context