-
Notifications
You must be signed in to change notification settings - Fork 39
refactor: Adjust Breakpoints for about/coc Page and Discuss lg Configuration Change #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: Adjust Breakpoints for about/coc Page and Discuss lg Configuration Change #573
Conversation
Fixed the issue where the grid layout did not activate at the intended screen size.
👷 Deploy request for classy-granita-bc2b5a pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for zesty-gnome-f04144 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@foxlee2525 如果把tailwind.config.js lg改成1024會如何? |
…odify affected pages - Refactored Tailwind `lg` breakpoint from 1024px to 1194px in tailwind.config.js. - Updated affected pages and media queries to align with the new breakpoint and ensure consistent grid behavior.
測試已知 「overview」 跟 「poster-session」兩個頁面的佈局受影響最大,所以相關頁面有做調整。 其他佈局目前看起來沒什麼問題,但可能還是要麻煩各位大大幫忙檢查一下,感謝! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
但兩個 Commit 看看要不要縮成一個
Types of changes
Description
在調整
about/coc
頁面的兩欄佈局斷點時,發現與專案中定義的lg
斷點設定不一致,因此進行了調整,以符合網頁 RWD 標準。Discussion Needed
建議將 TailwindCSS config 的
lg
斷點從1194px
修改為1024px
,以更符合常見的 RWD 標準。因為變動可能會影響到專案其他部分,因此希望先進行討論,再確認是否需要進行修改。
Next Steps
根據討論結果,確認是否需要將 TailwindCSS 配置中的 lg 斷點從 1194px 修改為 1024px。