-
-
Notifications
You must be signed in to change notification settings - Fork 700
feat(EvaluateAt): add support for children evaluated at edges #5190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5190 +/- ##
========================================
Coverage 98.79% 98.79%
========================================
Files 320 320
Lines 27092 27096 +4
========================================
+ Hits 26766 26770 +4
Misses 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Dharshannan does this fix your model? |
|
Yeap this fix works, thanks. |
yes can you please add another issue for this |
brosaplanella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We probably need an entry in the CHANGELOG for this.
brosaplanella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment in the CHANGELOG
Co-authored-by: Ferran Brosa Planella <[email protected]>
|
@martinjrobins I am happy with it, but my approval doesn't work because I made the last push. Not sure if you can approve. |
Dharshannan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@martinjrobins and @brosaplanella I can't approve as I do not have write access. @rtimms could you approve this? |
…-team#5190) * feat: EvaluateAt: add support for children evaluated at edges * add test for evaluate at edges * coverage * add changelog --------- Co-authored-by: Ferran Brosa Planella <[email protected]>
Description
Updates EvaluateAt so that it can have a child that is evaluated at edges
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests