Skip to content

Conversation

medha-14
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@medha-14 medha-14 requested a review from a team as a code owner August 27, 2025 08:56
@agriyakhetarpal agriyakhetarpal changed the title [GSoC 2025] Serialising Paramter Sets [GSoC 2025] Serialising Parameter Sets Aug 27, 2025
@agriyakhetarpal agriyakhetarpal added the GSoC 2025 Items being done as part of GSoC 2025 label Aug 27, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 85.22727% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.75%. Comparing base (3de0d8a) to head (6d479ca).

Files with missing lines Patch % Lines
src/pybamm/parameters/parameter_values.py 77.41% 7 Missing ⚠️
src/pybamm/expression_tree/operations/serialise.py 89.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5177      +/-   ##
===========================================
- Coverage    98.79%   98.75%   -0.05%     
===========================================
  Files          320      320              
  Lines        27092    27177      +85     
===========================================
+ Hits         26766    26838      +72     
- Misses         326      339      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC 2025 Items being done as part of GSoC 2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants