Skip to content

prevent indirect process object access #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madanagopalt wants to merge 6 commits into
base: master
Choose a base branch
from
Open

prevent indirect process object access #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b95e57
prevent indirect process object access
madanagopaltcomcast Dec 8, 2019
fd08265
Update install.sh
madanagopalt Dec 10, 2019
4aaac9a
Update build.sh
madanagopalt Dec 10, 2019
66ce28b
Update build.sh
madanagopalt Dec 10, 2019
c8ea12f
Update install.sh
madanagopalt Dec 10, 2019
269fc65
update linux externals [skip ci]
Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified artifacts/linux/lib/libnode.so.64
View file
Open in desktop
Binary file not shown.
44 changes: 44 additions & 0 deletions node-v10.15.3_mods.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1602,3 +1602,47 @@ index 834db64..0c108bd 100755
if defined openssl_no_asm set configure_flags=%configure_flags% --openssl-no-asm
if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose

diff --git a/libnode-v10.15.3/deps/v8/src/builtins/builtins-function.cc b/libnode-v10.15.3/deps/v8/src/builtins/builtins-function.cc
index df1dc19..d7d5bbf 100755
--- a/libnode-v10.15.3/deps/v8/src/builtins/builtins-function.cc
+++ b/libnode-v10.15.3/deps/v8/src/builtins/builtins-function.cc
@@ -12,6 +12,12 @@
#include "src/objects-inl.h"
#include "src/objects/api-callbacks.h"
#include "src/string-builder.h"
+/* MODIFIED CODE BEGIN */
+#include "src/api.h"
+#include "src/handles.h"
+
+using Utils = v8::Utils;
+/* MODIFIED CODE END */

namespace v8 {
namespace internal {
@@ -35,6 +41,10 @@ MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,
}

// Build the source string.
+/* MODIFIED CODE BEGIN */
+ v8::Local<v8::Context> callingCtx = reinterpret_cast<v8::Isolate*>(isolate)->GetCallingContext();
+ Handle<Context> callingCtxHandle = Utils::OpenHandle(*callingCtx);
+/* MODIFIED CODE END */
Handle<String> source;
int parameters_end_pos = kNoSourcePosition;
{
@@ -103,12 +113,14 @@ MaybeHandle<Object> CreateDynamicFunction(Isolate* isolate,
// come from here.
Handle<JSFunction> function;
{
+/* MODIFIED CODE BEGIN */
ASSIGN_RETURN_ON_EXCEPTION(
isolate, function,
Compiler::GetFunctionFromString(
- handle(target->native_context(), isolate), source,
+ handle(*callingCtxHandle, isolate), source,
ONLY_SINGLE_FUNCTION_LITERAL, parameters_end_pos),
Object);
+/* MODIFIED CODE END */
Handle<Object> result;
ASSIGN_RETURN_ON_EXCEPTION(
isolate, result,