Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to build from source #168

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

gogo2464
Copy link
Contributor

@gogo2464 gogo2464 commented Jun 2, 2024

Tell how to build ysoserial from source using command line. Inspired from the cicd.

@irsdl
Copy link
Collaborator

irsdl commented Jun 2, 2024

I think adding this without mentioning the Visual Studio compile or using Visual Studio command prompt might imply the need to use a different compilation process. If you have the time to add those too, that would be great.

We also have the following workflow if someone wants to use a github fork to build it:
https://github.com/pwntester/ysoserial.net/blob/master/.github/workflows/build.yml

I will wait for @pwntester to comment on this as this is to do with the documentation mainly.

@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 2, 2024

good idea! I will encourage the install of visual studio from chocolatey for a full cmd line linstall! seems cleaner. even on windows

@gogo2464 gogo2464 force-pushed the document-build-from-source branch from e146b29 to 5a2e79a Compare June 2, 2024 20:26
@pwntester
Copy link
Owner

LGTM, perhaps adding a line about the Action workflow as @irsdl mentioned

@gogo2464
Copy link
Contributor Author

In my humble opinion, people should have to look at the workflow:
-because of @use in cicd that may be confused
-because it might be considered as "my code api is not documented, read the directly."

If really you need it to merge, I am open.

@gogo2464
Copy link
Contributor Author

is it ready to merge?

@pwntester pwntester merged commit 1f7aaa9 into pwntester:master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants