93 refactor generic build pipeline #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent variables for better clarity and maintainability
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the generic build pipeline by updating the GitHub Actions workflow.
- Introduces a manual trigger (workflow_dispatch) for the build.
- Splits the pipeline into dedicated jobs (lint, build_and_push, deploy, and comment).
- Updates environment variable usage and Helm-related commands for deployment consistency.
Comments suppressed due to low confidence (1)
.github/workflows/build.yaml:14
- [nitpick] Consider renaming 'TRAINING_VERSION' for consistency with 'HELM_RELEASE' and 'HELM_NAME', for example to 'HELM_VERSION'.
TRAINING_VERSION: ${{ github.sha }}
|
|
||
| jobs: | ||
| build: | ||
| lint: |
There was a problem hiding this comment.
[nitpick] Consider adding caching for npm dependencies in the 'lint' job to improve workflow performance.
Copilot uses AI. Check for mistakes.
…load step for improved build process
…ry checkout for improved consistency
…redundant artifact download
chrira
merged commit 9dace25
into
puzzle:93-refactor-generic-build-pipeline
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.