fix: enforce sandbox validation, atomic replacement & main-thread result payload #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harden native unarchive implementations on both platforms. Enforce app-sandbox output paths, perform atomic final swaps, and ensure bridge-safe result construction on the main thread. Adds cancellation and relative-path metadata, updates TypeScript spec and docs.
Key changes
iOS (
ios/Unarchive.mm,ios/Unarchive.h)isOutputPathInSandbox:and early rejection withUNARCHIVE_INVALID_PATH.replaceItemAtURL:withItemAtURL:(with appropriate fallback/cleanup).cancelUnarchive) and improved debug diagnostics.Android (
android/src/main/java/com/unarchive/UnarchiveModule.kt)isPathAllowed()(app-scoped paths only).atomicMoveOrFallback).FileOutputStreamper entry and stream-safe extraction.isActivechecks.WritableNativeArray/WritableNativeMaponDispatchers.Main.TypeScript / JS
src/NativeUnarchive.ts/src/index.tsx:cancelUnarchive()andCancelResult.relativePathtoFileInfo.Docs / Release
README.mdwith sandbox/path/security guidance and new API docs.CHANGELOG.md.Files worth reviewing
Migration notes / Breaking changes
DocumentDirectoryPath,CachesDirectoryPath, orTemporaryDirectoryPath).context.filesDir,context.cacheDir, orcontext.getExternalFilesDir(null)(useDocumentDirectoryPathor app-specific external files path).UNARCHIVE_BUSY.error.codefor programmatic handling (new, granular error codes).