Skip to content

fix: update video orientation handling in CameraView for session readiness #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushpender-singh-ap merged 4 commits into from
Nov 25, 2025
Merged

fix: update video orientation handling in CameraView for session readiness #64

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a037bea
fix: update video orientation handling in CameraView for session read…
pushpender-singh-ap Nov 25, 2025
3013002
fix: improve video orientation handling in CameraView to support inte…
pushpender-singh-ap Nov 25, 2025
f7b3bad
fix: add orientation change handling in CameraView and manage observe…
pushpender-singh-ap Nov 25, 2025
b05142f
fix: manage device orientation notifications in CameraView setup and …
pushpender-singh-ap Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions ios/CameraView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public class CameraView: UIView {
guard let self = self else { return }
if let previewLayer = self.previewLayer {
previewLayer.session = session
previewLayer.connection?.videoOrientation = .portrait
self.updateVideoOrientation()
print("✅ Preview layer bound to session from onSessionReady callback")
} else {
print("⚠️ Preview layer missing when session became ready")
Expand All @@ -62,7 +62,7 @@ public class CameraView: UIView {
guard let self = self, let previewLayer = self.previewLayer else { return }
if let existingSession = existingSession {
previewLayer.session = existingSession
previewLayer.connection?.videoOrientation = .portrait
self.updateVideoOrientation()
print("✅ Preview layer bound to existing session")
}
}
Expand All @@ -73,6 +73,26 @@ public class CameraView: UIView {
public override func layoutSubviews() {
super.layoutSubviews()
previewLayer?.frame = bounds
updateVideoOrientation()
}

private func updateVideoOrientation() {
guard let connection = previewLayer?.connection, connection.isVideoOrientationSupported else { return }

let orientation = UIDevice.current.orientation

switch orientation {
case .portrait:
connection.videoOrientation = .portrait
case .landscapeRight:
connection.videoOrientation = .landscapeLeft
case .landscapeLeft:
connection.videoOrientation = .landscapeRight
case .portraitUpsideDown:
connection.videoOrientation = .portraitUpsideDown
default:
break
}
}

deinit {
Expand Down