fix: add Swift bridging header support and module name in podspec #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The podspec explicitly enables module support - The bridging header name is explicitly set - The import statement handles both framework structures - Works with both static and dynamic linkage
3 tasks
pushpender-singh-ap
deleted the
53-ios-build-crash-when-use_frameworks-linkage-static
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
use_frameworks! :linkage => :static, CocoaPods builds static frameworks instead of dynamic ones. The problem with this library arises because:CameraViewand related classes)CameraViewManager.mm)#import "ReactNativeScanner-Swift.h"Why it fails with static frameworks
ModuleName-Swift.h), exposing Swift classes to Objective-C.Without the bridging header, the Objective-C++ file cannot access the Swift classes, which leads to compilation errors.
Solutions added
This should resolve the issue and make the library work regardless of whether CocoaPods is using static or dynamic frameworks.