Skip to content

fix: android build rn 0.77.0 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushpender-singh-ap merged 3 commits into from
Feb 2, 2025
Merged

fix: android build rn 0.77.0 #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
988d442
React Native 0.77.0 Android Build Fix
tugberkulucan Jan 29, 2025
e3f761b
Merge pull request #1 from ulucantugberk/rn-0-77-android-fix
ulucantugberk Jan 29, 2025
373b348
Make view parameters non-nullable in methods
pushpender-singh-ap Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions ...oid/src/main/java/com/pushpendersingh/reactnativescanner/ReactNativeScannerViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import com.facebook.react.viewmanagers.ReactNativeScannerViewManagerDelegate
@ReactModule(name = ReactNativeScannerViewManager.NAME)
class ReactNativeScannerViewManager(private val mCallerContext: ReactApplicationContext) :
SimpleViewManager<ReactNativeScannerView>(),
ReactNativeScannerViewManagerInterface<ReactNativeScannerView?> {
ReactNativeScannerViewManagerInterface<ReactNativeScannerView> {

private val mDelegate: ViewManagerDelegate<ReactNativeScannerView>

Expand All @@ -29,42 +29,42 @@ class ReactNativeScannerViewManager(private val mCallerContext: ReactApplication
}

@ReactProp(name = "pauseAfterCapture")
override fun setPauseAfterCapture(view: ReactNativeScannerView?, value: Boolean) {
view?.setPauseAfterCapture(value)
override fun setPauseAfterCapture(view: ReactNativeScannerView, value: Boolean) {
view.setPauseAfterCapture(value)
}

@ReactProp(name = "showBox")
override fun setShowBox(view: ReactNativeScannerView?, value: Boolean) {
view?.setShowBox(value)
override fun setShowBox(view: ReactNativeScannerView, value: Boolean) {
view.setShowBox(value)
}

@ReactProp(name = "isActive")
override fun setIsActive(view: ReactNativeScannerView?, value: Boolean) {
view?.setIsActive(value)
override fun setIsActive(view: ReactNativeScannerView, value: Boolean) {
view.setIsActive(value)
}

override fun enableFlashlight(view: ReactNativeScannerView?) {
view?.enableFlashlight()
override fun enableFlashlight(view: ReactNativeScannerView) {
view.enableFlashlight()
}

override fun disableFlashlight(view: ReactNativeScannerView?) {
view?.disableFlashlight()
override fun disableFlashlight(view: ReactNativeScannerView) {
view.disableFlashlight()
}

override fun releaseCamera(view: ReactNativeScannerView?) {
view?.releaseCamera()
override fun releaseCamera(view: ReactNativeScannerView) {
view.releaseCamera()
}

override fun stopScanning(view: ReactNativeScannerView?) {
view?.stopScanning()
override fun stopScanning(view: ReactNativeScannerView) {
view.stopScanning()
}

override fun resumeScanning(view: ReactNativeScannerView?) {
view?.resumeScanning()
override fun resumeScanning(view: ReactNativeScannerView) {
view.resumeScanning()
}

override fun startCamera(view: ReactNativeScannerView?) {
val reactAppContext = view?.context as? ReactApplicationContext
override fun startCamera(view: ReactNativeScannerView) {
val reactAppContext = view.context as? ReactApplicationContext
reactAppContext?.let {
view.setUpCamera(it)
}
Expand All @@ -79,4 +79,4 @@ class ReactNativeScannerViewManager(private val mCallerContext: ReactApplication
companion object {
const val NAME = "ReactNativeScannerView"
}
}
}