Skip to content

72 cea tx type funds and payload#73

Merged
zaryab2000 merged 5 commits intocea_v1from
72_cea_txType_fundsAndPayload
Feb 20, 2026
Merged

72 cea tx type funds and payload#73
zaryab2000 merged 5 commits intocea_v1from
72_cea_txType_fundsAndPayload

Conversation

@zaryab2000
Copy link
Collaborator

@zaryab2000 zaryab2000 commented Feb 16, 2026

this fixes #72


v2 review fixes

  • sendUniversalTxToUEA: Removed payload.length == 0 branching — all calls (FUNDS and
    FUNDS_AND_PAYLOAD) now route through sendUniversalTxViaCEA unconditionally
  • _handleExecution: Replaced two-path routing (multicall vs single-call with inline migration
    detection) with a clean three-way branch: isMulticall → _handleMulticall, isMigrationPayload →
    _handleMigration, else → _handleSingleCall
  • _handleMulticall: Removed totalValue accumulation loop and msg.value != totalValue revert (CEA
    can now spend pre-existing balance alongside Vault-provided msg.value). Added
    isMigration(calls[i].data) guard that reverts InvalidCall to prevent migration selector inside
    multicall arrays
  • _handleMigration: Simplified from _handleMigration(Multicall memory call) to _handleMigration()
    — no params, no target/value validation. Fetches migration contract from factory and
    delegatecalls directly. Migration is now a top-level payload, not wrapped in a Multicall struct
  • Added isMigrationPayload(bytes calldata): New private helper (calldata variant) for top-level
    migration detection in _handleExecution's three-way branch, alongside the existing
    isMigration(bytes memory) used for in-loop multicall checking
  • Fixed unused variable warning: Changed (bool success, bytes memory returnData) to (bool
    success,) in _handleMulticall

@0xNilesh 0xNilesh self-requested a review February 20, 2026 06:54
@zaryab2000 zaryab2000 merged commit d83f99b into cea_v1 Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments