ui: add background color picker for windows#3
Open
tincho70 wants to merge 1 commit intopurrgrammer:mainfrom
Open
ui: add background color picker for windows#3tincho70 wants to merge 1 commit intopurrgrammer:mainfrom
tincho70 wants to merge 1 commit intopurrgrammer:mainfrom
Conversation
Owner
|
hey Tincho, thanks for the contribution. one issue with this is that the text colors might have poor contrast with the color choices hardcoded here, and makes my job designing the theme way harder since there's lots of combinations. i have started working on a theme system for grimoire, where we can define alternative themes, perhaps we could use that to be able to give alternative colors to windows? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

It allows you to visually differentiate windows, especially in configurations for large monitors.