Skip to content

ui: add background color picker for windows#3

Open
tincho70 wants to merge 1 commit intopurrgrammer:mainfrom
tincho70:ui-background-color
Open

ui: add background color picker for windows#3
tincho70 wants to merge 1 commit intopurrgrammer:mainfrom
tincho70:ui-background-color

Conversation

@tincho70
Copy link

It allows you to visually differentiate windows, especially in configurations for large monitors.

@purrgrammer
Copy link
Owner

hey Tincho, thanks for the contribution. one issue with this is that the text colors might have poor contrast with the color choices hardcoded here, and makes my job designing the theme way harder since there's lots of combinations. i have started working on a theme system for grimoire, where we can define alternative themes, perhaps we could use that to be able to give alternative colors to windows?

@tincho70
Copy link
Author

You're welcome! The pleasure of (trying to) help is all mine 🙂
I had tried these colors and they seemed to work well, but now I think it might be because I have the dark theme on my PC...

Screenshot_2

I don't know how to work with Blueprint (I understand it's the theme scheme you're using now), and I didn't have time to figure it out. I wanted to offer something for you to iterate on, so I think it's excellent that you're integrating it with your theme system, as I still believe it helps improve visuals on large monitors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants