Update modules for Go 1.21 & fix breaking changes #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several types were renamed and moved Signed-off-by: Joe Groocock <[email protected]>
Signed-off-by: Joe Groocock <[email protected]>
|
sweet! Docker patch LGTM, consider that merged. The other patch... So please teach me how I could have written that, and what commands I run to get to the same result... I've talked about that a bit here: #749 Note I tried to write a commit like yours, but see my issue in the last image message on that above issue... |
|
For the second commit, I just did |
|
Honestly something like Renovate or Dependabot might be a good idea if you don't want to have to think about bumping deps. |
|
On Sat, Apr 27, 2024 at 10:04 AM Joe Groocock ***@***.***> wrote:
Honestly something like Renovate or Dependabot might be a good idea if you don't want to have to think about bumping deps.
If it's something that can run standalone in the repo without needing
some cloud service, then yeah, sounds like #749 and patches welcome =D
|
|
Renovate seems to be open source https://github.com/renovatebot/renovate |
|
So I have a feature branch I just pushed which (1) takes your docker commit (which I plan to merge shortly) and then I manually did I then did a diff between that and your commit and I got the following: I have no doubt that what you pushed was correct, but the fact that this is not deterministic and that we don't converge on the same result bothers me... So either (1) I'm doing something wrong (2) you're doing something wrong (3) golang mod is broken or (4) all of the above. Please let me know what you think I should merge and why. Thanks! |
|
The differences are probably because you didn't add the replace lines that I added. Try adding those two and running |
|
Side note, I removed these b650269#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R158-R159 |
|
If I remove the hence the Adding that ^ and then running hence the second replace although now I'm into "the author of However you spin it though, without these changes I couldn't build mgmt due to the errors above that the two replace lines fixed. I'd be more curious if you could build mgmt after blasting away your go mod cache with |
I'm not sure I would blame them, at least to me this is very confusing. I've already merged your docker patch, and I'm going to merge the variant I have because it seems to pass CI. The replace stuff you did is legitimate, but I think it's inside a dep somewhere, so I assume those will get fixed automatically when the dep gets updated. If you have any issues with git master, please let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.