Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace version badges pointing to spago-legacy 0.21 with new Spago version #1326

Merged

Conversation

peterbecich
Copy link
Contributor

@peterbecich peterbecich commented Feb 9, 2025

Description of the change

There are two badges in the readme which are misleading.
The first points to spago@latest on NPM. The second points to the latest GitHub Packages in this repository, which has not been updated from spago-legacy.

This PR updates both badges.

The NPM badge is configured to point to spago@next on NPM, via: https://shields.io/badges/npm-version-with-dist-tag
Preview:
NPM Version (with dist tag)

The badge which replaces the GitHub Packages release version is configured via: https://shields.io/badges/dynamic-yaml-badge
It works by extracting the version from
https://raw.githubusercontent.com/purescript/spago/refs/heads/master/spago.yaml at path package.publish.version
Preview:
Latest release

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

@peterbecich peterbecich force-pushed the replace-latest-release-readme-badge branch from 3c39166 to 2f7922d Compare February 11, 2025 05:20
@peterbecich peterbecich changed the title replace version badge pointing to spago-legacy 0.21 with new Spago version replace version badges pointing to spago-legacy 0.21 with new Spago version Feb 11, 2025
@peterbecich
Copy link
Contributor Author

@f-f please review, this will fix the outdated version numbers at the top of the readme

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@f-f f-f merged commit 01cc874 into purescript:master Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants