-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter path types for stricter path-related logic #1296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
commented
Oct 25, 2024
fsoikin
commented
Oct 27, 2024
…l fear no forward slashes
fsoikin
commented
Oct 31, 2024
This was referenced Nov 1, 2024
Closed
2 tasks
fsoikin
commented
Jan 17, 2025
f-f
reviewed
Jan 18, 2025
fsoikin
commented
Jan 19, 2025
Alright, I finally figured out the Windows failure, and it turned out to be an actual potential problem, not just a silly forward vs. back slash issue. I added special handling for it and some tests. |
fsoikin
commented
Jan 19, 2025
fsoikin
commented
Jan 19, 2025
f-f
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now - awesome job 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Summary of prior discussion:
cwd
value isunsafePerformEffect
ed at init and then ends up baked into various values around the code.spago script
.In this pull request:
Spago.Path
RootPath
,LocalPath
, andGlobalPath
. See comments on the types for explanation.Spago.FS
, take strongly typed paths as parameters.rootPath :: RootPath
and use that path as root for all operations, no longer relying on CWD for this purpose.registry
, don't need a root path.Checklist:
[ ] Added some example of the new feature to theREADME