Print compact stats instead of verbose when no errors or warnings #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
force-pushed
the
issue-1195-empty-verbose-stats
branch
from
9075491 to
f771e7e
Compare
fsoikin
commented
Jul 25, 2024
Comment on lines
-8
to
+14
| ( buildOutput | ||
| , Output | ||
| ( Output | ||
| , OutputStats | ||
| , annotatedError | ||
| , trimPosition | ||
| , buildOutput | ||
| , initialStats | ||
| , trimMessage | ||
| , trimPosition |
There was a problem hiding this comment.
This got sorted alphabetically by the IDE support. The only real change is exporting initialStats to use it in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #1195
When there are no errors or warnings, we're just delegating to
renderStatsto print all zeroes.Checklist:
[ ] Added some example of the new feature to theREADME