Re:Hydration #54
Open
Re:Hydration #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Serhii Khoma <[email protected]>
Co-Authored-By: Serhii Khoma <[email protected]>
Co-Authored-By: Serhii Khoma <[email protected]>
Co-Authored-By: Serhii Khoma <[email protected]>
Co-Authored-By: Serhii Khoma <[email protected]>
Co-Authored-By: Serhii Khoma <[email protected]>
This puts the various xProp functions inside buildProp at the module level to prepare for code-sharing with the hydrateProp implementation. Co-Authored-By: Serhii Khoma <[email protected]>
|
Up to 83b8772, the changes have been relatively simple as a lot of the shared code between rendering/hydration already exists at the module level. What's a little more difficult is implementing |
srghma
reviewed
Apr 3, 2025
| Basic.elem "div" [ "id" := "root" ] $ | ||
| if isClient then [] | ||
| else [ Basic.elem "span" [] [ Basic.text "Server!" ] ] | ||
| expectError $ renderHydrate mismatch |
There was a problem hiding this comment.
I would also add a test
- if trying to hydrate
Basic.elem "div" [ "] [ Basic.text "1", Basic.text "2" ]on<div>12</div>then it will not throw error (bc it should splitTEXT_NODE "12"onTEXT_NODE "1"andTEXT_NODE "2" - if trying to hydrate
Basic.elem "div" [ "] [ Basic.text "1", Basic.text "" ]on<div>1</div>then it will not throw error (bc it should add toTEXT_NODE "1"theTEXT_NODE ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37 and #38. This picks up on the awesome work done by @srghma on #38 with the goal of producing a smaller diff.
TODO
specandspec-mochacc: @garyb @natefaubion