Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes "float" parser of GenTokenParser parse negative numbers. #225

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

mstream
Copy link
Contributor

@mstream mstream commented Apr 29, 2023

Resolves #115

Makes the float parser consider a sign, if present, in front of a floating number.

@jamesdbrock
Copy link
Member

Hi @mstream thanks for the PR! This looks like good work, and I intend to merge it unless I find some surprising problem.

I see that you have already found most of the other issues and commentary around this. I suggest that you use the
number parser instead? number is better because it round-trips with show :: Number -> String (in a JavaScript environment).

The thing about this float parser is that the whole Token module and everything in it is mostly unmaintained, and will probably be factored out into a separate package some day as soon as someone feels like doing that work.
#142 (comment)

@jamesdbrock
Copy link
Member

the whole Token module and everything in it is mostly unmaintained, and will probably be factored out into a separate package some day as soon as someone feels like doing that work.

Actually we didn't have an issue for that yet so I just made one. #226

@jamesdbrock jamesdbrock merged commit d6dd52c into purescript-contrib:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Float parser does not parse negative numbers
2 participants