Skip to content

Add lower parser to Text.Parsing.Parser.String.Basic #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mkohlhaas
Copy link
Contributor

Add lower parser to Text.Parsing.Parser.String.Basic.

See also #151

Would also like to export helper function satisfyCP if it makes sense to you.

I didn't add tests for this change.
I had to change spago.dhall to make a build.

My purs version is: 0.14.5
spago: 0.20.7

@jamesdbrock
Copy link
Member

Thanks for the PR!

There is already a satisfyCodePoint parser. https://pursuit.purescript.org/packages/purescript-parsing/8.2.0/docs/Text.Parsing.Parser.String#v:satisfyCodePoint , I don't think we should export satisfyCP, it’s an odd little helper function which satisfies a CodePoint predicate but returns a Char.

Why was it necessary to add unfoldable to spago.dhall?

@mkohlhaas
Copy link
Contributor Author

No idea. No build possible without it. Basically spago told me so and I followed.

Is there any way to find out the reason for me?

(As you can tell by now I'm a PureScript and Haskell beginner.)

@jamesdbrock
Copy link
Member

Oops, it looks like I broke the build in the last version v8.2.0 by not adding unfoldable to spago.dhall. Thanks for noticing!

@jamesdbrock jamesdbrock merged commit 66ac624 into purescript-contrib:main Mar 13, 2022
@jamesdbrock
Copy link
Member

@jamesdbrock
Copy link
Member

Thanks again for the PR @mkohlhaas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants