Shorten the conditionals in apt::source #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
simplify-conditionals
branch
from
ba4aec5 to
e474dfe
Compare
Rather than writing:
type($release, 'generalized') !~ Type[Array]
This uses:
$release !~ Array
Which is equal, but shorter.
It also refactors some conditionals merge some branches which results in
shorter code and arguably easier to read.
ekohl
force-pushed
the
simplify-conditionals
branch
from
e474dfe to
762f688
Compare
bastelfreak
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rather than writing:
This uses:
$release !~ ArrayWhich is equal, but shorter.
It also refactors some conditionals merge some branches which results in shorter code and arguably easier to read.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Initially introduced in #1167.
Checklist
puppet apply)