Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ensure for ppa lock file #1211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

llavaud
Copy link

@llavaud llavaud commented Dec 9, 2024

Summary

The lock file used by the apt::ppa resource miss the ensure => file attribute and so never created leading to a constant repository installation.

Related Issues (if any)

Fix issue #1210

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

- The lock file used by the apt::ppa resource miss the `ensure => file`
  attribute and so never created leading to a constant repository
installation.
@llavaud llavaud requested review from bastelfreak, smortex and a team as code owners December 9, 2024 08:16
@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

@llavaud
Copy link
Author

llavaud commented Jan 6, 2025

@smortex @bastelfreak Hello, any comments regarding this PR ?

@bastelfreak
Copy link
Collaborator

Hello,
I try to avoid reviews for Perforce code until they sorted out their licensing ( https://www.puppet.com/blog/open-source-puppet-updates-2025 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants