Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install mod_http2 on EL if required #2593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Mar 10, 2025

Summary

In EL8 httpd had a hard requirement on mod_http2 but in EL9 it turned into a weak dependency. While most installs default to installing weak dependencies, it can be disabled by users (by setting install_weak_deps=0 in /etc/dnf/dnf.conf). OracleLinux even defaults to disabled.

EL7 doesn't have http2 at all so the whole class can't be used with it.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Still a draft, but having a PR makes it easy for me to test.

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@ekohl ekohl added the bugfix label Mar 10, 2025
ekohl added 2 commits March 10, 2025 17:29
Fixes: cedd45b ("Drop Apache 2.2 support")
In EL8 httpd had a hard requirement on mod_http2 but in EL9 it turned
into a weak dependency. While most installs default to installing weak
dependencies, it can be disabled by users. OracleLinux even defaults to
disabled.

EL7 doesn't have http2 at all so the whole class can't be used with it.
@ekohl ekohl force-pushed the require-mod_http2 branch from 3dc79ee to 5c41406 Compare March 10, 2025 16:35
@ekohl ekohl marked this pull request as ready for review March 10, 2025 16:35
@ekohl ekohl requested review from bastelfreak, smortex and a team as code owners March 10, 2025 16:35
@ekohl
Copy link
Collaborator Author

ekohl commented Mar 10, 2025

Includes #2594 because without it the tests would immediately fail.

smortex
smortex previously approved these changes Mar 10, 2025
@ekohl ekohl dismissed smortex’s stale review March 11, 2025 09:14

The merge-base changed after approval.

bastelfreak
bastelfreak previously approved these changes Mar 11, 2025
@ekohl ekohl dismissed bastelfreak’s stale review March 11, 2025 09:21

The merge-base changed after approval.

smortex
smortex previously approved these changes Mar 19, 2025
@ekohl ekohl dismissed smortex’s stale review March 19, 2025 06:23

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants