-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ubuntu 24.04 #2585
base: main
Are you sure you want to change the base?
Conversation
8ffc695
to
8a7895a
Compare
The used facterdb version has no factsets for Ubuntu 24.04. That means that no unit tests will test Ubuntu 24.04. I highly recommend to update to a newer FacterDB version first. |
Any news here? We also need adoptions for 24.04 auth_kerb apt package name. |
A new facterdb version with 24.04 facts was released so that should be resolved now
That isn't mentioned in this PR. Could you explain what actually changed and what code changes are expected? |
Can I contribute via this fork here or would I have to create a new one?
With Ubuntu 24.04 the package |
it's not that easy. Perforce pins to an ancient FacterDB version in this module: https://github.com/puppetlabs/puppetlabs-apache/blob/main/Gemfile#L25. This is based on a template from https://github.com/puppetlabs/pdk-templates/blob/main/config_defaults.yml. And that got recently updated to allow FacterDB 3.X: puppetlabs/pdk-templates@d37befc. I do not know what the desired workflow is to roll out those changes to modules. |
Summary
This adds support for Ubuntu 24.04
Additional Context
n/a
Related Issues (if any)
I see #2577 which did not add the acceptance tests nor the determination of the according php version.
Checklist
puppet apply
)