Skip to content

Unit test updates #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Unit test updates #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
811ecf2
Use bundler-cache
mhashizume Jul 1, 2024
47c87e4
Update FFI gem
mhashizume Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/unit_tests_with_nightly_puppet_gem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ jobs:
env_set_cmd: '$env:'
# setup-ruby uses ucrt for newer Rubies, but we only support mingw
# in our Windows Puppet nightly gems. For now, we'll just install
# the universal gem and manually install the ffi dependency
# the universal gem and manually install the ffi dependency.
# Use the latest known good version of the ffi gem.
gem_file: 'puppet-latest.gem'
extra_steps: 'gem install ffi --version 1.15.5'
extra_steps: 'gem install ffi --version 1.16.3'

runs-on: ${{ matrix.os }}
steps:
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/unit_tests_with_released_puppet_gem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}

- name: Prepare testing environment with bundler
run: |
git config --global core.longpaths true
bundle config set system 'true'
bundle config set --local without 'release'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter that we lost these configurations? It's possible to set these as environment variables (at least for the latter two, not sure about global git config)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the longpaths configuration anymore--it was initially implemented because of the GitHub Changelog Generator repo: puppetlabs/puppetlabs-augeas_core#35

But we no longer use that Changelog Generator anymore, so I don't think we need the option.

This action is used by the core modules and the puppet_agent module, none of which have a "release" group in their Gemfiles. We won't lose anything by removing this configuration.

The Bundler docs don't seem to have anything on bundle config set system 'true', but it seems like it sets all future Bundler configuration to take place at the system level (as opposed to local/global). If that's the case, then we're not doing any additional Bundler configuration so it doesn't matter anyway.

bundle update --jobs 4 --retry 3
bundler-cache: true

- name: Run unit tests
run: bundle exec rake parallel_spec