Skip to content

Conversation

@blampe
Copy link
Contributor

@blampe blampe commented Aug 27, 2025

I'm seeing an issue where this test can sometimes fail because it ends up installing p-k v4.15 (a version that predates the await logic under test). I was able to reproduce the issue locally. I suspect other jobs are passing perhaps because they have a more recent provider cached?

In any case, we want this test to run against the checked out provider and not something that's been released.

Update the test to point at the local binary.

@blampe blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Aug 27, 2025
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.45%. Comparing base (4270490) to head (d206ee9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3791      +/-   ##
==========================================
+ Coverage   42.42%   42.45%   +0.03%     
==========================================
  Files          87       87              
  Lines       12693    12693              
==========================================
+ Hits         5385     5389       +4     
+ Misses       6911     6907       -4     
  Partials      397      397              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/no-changelog-required This issue doesn't require a CHANGELOG update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant