Skip to content

Update Snowflake case study details #16397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update Snowflake case study details #16397

wants to merge 5 commits into from

Conversation

@scottmparker
Copy link
Contributor

Added logo and description for Snowflake case study.

Proposed changes

Unreleased product version (optional)

Related issues (optional)

asafashirov and others added 5 commits October 22, 2025 13:59
@asafashirov
Add GADS category landing pages
33bb872 
Created six new category landing pages for the Google Ads campaign: Infrastructure as Code, Platform Engineering, DevOps Automation, Developer Platforms, Cloud Infrastructure Automation, and Multicloud. Each page includes category-specific titles, headings, and utm_source tracking parameters.
@asafashirov
Fix style guide violations in category pages
0b1720a 
Removed usage of 'easiest' and 'simple' per STYLE-GUIDE.md which prohibits words that judge difficulty. Changed 'smartest and easiest way' to 'most comprehensive way', 'fastest and easiest way' to 'Use Pulumi IaC at scale', and 'simple queries' to 'powerful queries' across all six category landing pages.
@asafashirov
Consolidate GADS pages from 6 to 3 persona-based pages
d34b823 
Based on feedback, consolidated from 6 category pages to 3 persona-based landing pages:

1. Platform Teams (/gads/platform-teams/) - merges platform engineering + developer platforms
   Keywords: platform engineering, internal developer platform, developer productivity platform

2. Infrastructure/DevOps Engineers (/gads/infrastructure-engineers/) - merges IaC + DevOps automation + cloud infrastructure automation
   Keywords: IaC tools, DevOps automation, cloud infrastructure automation

3. Multi-Cloud Operations (/gads/multicloud/) - kept separate
   Keywords: multi-cloud, cross-cloud, hybrid cloud

Each page uses appropriate UTM source tracking and category-specific DKI placeholders. All pages maintain style guide compliance (no 'easiest' or 'simple').
@scottmparker
Revise infrastructure engineers page for clarity and speed
0a1f233 
Updated the content to emphasize faster infrastructure deployment using programming languages and improved descriptions for key features and case studies.
@scottmparker
Update Snowflake case study details
93ed64e 
Added logo and description for Snowflake case study.
@claude
Copy link
Contributor

claude bot commented Oct 27, 2025

Review Findings

This PR has significant issues that need to be addressed before merging.

Critical Issues

  1. Massive unintended content deletion (lines 1-224)

    • The PR removes 210 lines of essential content including frontmatter, layout configuration, headings, overview sections, key features, stats, and detailed content
    • The PR description says "Added logo and description for Snowflake case study" but the change actually deletes almost the entire file
    • This appears to be an accidental deletion rather than an intentional refactoring

  2. Missing frontmatter (line 1)

    • The file is missing all Hugo frontmatter delimiters (---) and fields
    • Required fields missing: meta_desc, layout, heading, subheading, and others
    • Without proper frontmatter, this page will not render correctly

  3. Incomplete document structure

    • The file now contains only a case_studies YAML fragment with no proper document structure
    • This is not a valid Hugo content file

Style Issues

  1. Missing newline at end of file (line 21)

    • Per AGENTS.md: "Markdown must always end with a newline"
    • Add a newline after line 20

  2. Missing punctuation (line 20)

    • The Snowflake description should end with a period for consistency with other case study descriptions

    Suggestion:

    description: Built a multi-cloud, Kubernetes-based platform to standardize all deployments.

  3. Misleading PR description

    • The description states the change adds "logo and description for Snowflake case study"
    • Actually, logo fields were added to ALL six case studies (Atlassian, Elkjop, Starburst, BMW, Lemonade, and Snowflake)
    • No descriptions were changed; only logo fields were added

Recommendation

This change needs to be completely reworked. The correct approach would be to:

  1. Restore all the deleted content (lines 1-210 from the original file)
  2. Add only the logo: fields to each case study entry (which appears to be the actual intent)
  3. Ensure the file ends with a newline
  4. Update the PR description to accurately reflect the changes

Mention @claude if you'd like me to help fix these issues or review again after updates.

Base automatically changed from gads-categories to master October 28, 2025 18:25
@meagancojocar
Copy link
Collaborator

Looks like this does not add a snowflake logo or description as intended, it makes changes already in production. Should we close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scottmparker @meagancojocar @asafashirov